Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15393005: [chromedriver] Remove unnecessary round trips to Chrome. (Closed)

Created:
7 years, 7 months ago by kkania
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Remove unnecessary round trips to Chrome. Change alerts system to not request page info from DevTools each command. Also don't fetch main frame ID each time, since NavigationTracker doesn't really need it. BUG=none R=chrisgao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202610

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : again #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -263 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/alert_commands.h View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/alert_commands.cc View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome.h View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_impl.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_impl.cc View 1 2 3 chunks +2 lines, -58 lines 0 comments Download
M chrome/test/chromedriver/chrome/javascript_dialog_manager.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_chrome.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_chrome.cc View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_web_view.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/stub_web_view.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.cc View 1 2 2 chunks +5 lines, -25 lines 0 comments Download
M chrome/test/chromedriver/command_executor_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/session_commands.h View 1 2 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 2 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
7 years, 7 months ago (2013-05-23 00:05:01 UTC) #1
chrisgao (Use stgao instead)
lgtm
7 years, 7 months ago (2013-05-23 04:31:07 UTC) #2
chrisgao (Use stgao instead)
seems you forgot to upload alert_commands.cc/h
7 years, 7 months ago (2013-05-24 18:54:41 UTC) #3
kkania
7 years, 6 months ago (2013-05-28 18:40:51 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as r202610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698