Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 15393005: [chromedriver] Remove unnecessary round trips to Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h
index c0f97b745c559db2424944d2f057d09a238f95a1..9701643c5aeec5f7f8bfaae13fd3d5edeb7cd053 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_impl.h
@@ -34,11 +34,6 @@ class ChromeImpl : public Chrome {
virtual Status GetWebViewById(const std::string& id,
WebView** web_view) OVERRIDE;
virtual Status CloseWebView(const std::string& id) OVERRIDE;
- virtual Status IsJavaScriptDialogOpen(bool* is_open) OVERRIDE;
- virtual Status GetJavaScriptDialogMessage(std::string* message) OVERRIDE;
- virtual Status HandleJavaScriptDialog(
- bool accept,
- const std::string* prompt_text) OVERRIDE;
virtual Status GetAutomationExtension(
AutomationExtension** extension) OVERRIDE;
@@ -56,8 +51,6 @@ class ChromeImpl : public Chrome {
private:
typedef std::list<linked_ptr<WebViewImpl> > WebViewList;
- Status GetDialogManagerForOpenDialog(JavaScriptDialogManager** manager);
-
std::string version_;
int build_no_;
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698