chrome/test/chromedriver/chrome/web_view_impl.h - Issue 15393005: [chromedriver] Remove unnecessary round trips to Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.h

Issue 15393005: [chromedriver] Remove unnecessary round trips to Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/web_view_impl.h

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.h b/chrome/test/chromedriver/chrome/web_view_impl.h

index 337e651eabed449e620a1ffd91dc655a9a99c528..ae15a7d608cbf5747f96479ae365342e4c53a427 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.h

+++ b/chrome/test/chromedriver/chrome/web_view_impl.h

@@ -39,6 +39,7 @@ class WebViewImpl : public WebView {

// Overridden from WebView:

virtual std::string GetId() OVERRIDE;

virtual Status ConnectIfNecessary() OVERRIDE;

+ virtual DevToolsClient* GetDevToolsClient() OVERRIDE;

virtual Status Load(const std::string& url) OVERRIDE;

virtual Status Reload() OVERRIDE;

virtual Status EvaluateScript(const std::string& frame,

@@ -73,7 +74,6 @@ class WebViewImpl : public WebView {

const std::string& frame_id) OVERRIDE;

virtual Status IsPendingNavigation(

const std::string& frame_id, bool* is_pending) OVERRIDE;

- virtual Status GetMainFrame(std::string* out_frame) OVERRIDE;

virtual JavaScriptDialogManager* GetJavaScriptDialogManager() OVERRIDE;

virtual Status OverrideGeolocation(const Geoposition& geoposition) OVERRIDE;

virtual Status CaptureScreenshot(std::string* screenshot) OVERRIDE;