Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5465)

Unified Diff: chrome/test/chromedriver/chrome/web_view.h

Issue 15393005: [chromedriver] Remove unnecessary round trips to Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_web_view.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view.h
diff --git a/chrome/test/chromedriver/chrome/web_view.h b/chrome/test/chromedriver/chrome/web_view.h
index f15605c26d209c6106553f6eaf9727e04fcab294..a4ed6a78b85ea89dc94373d8140fbf9ab6919071 100644
--- a/chrome/test/chromedriver/chrome/web_view.h
+++ b/chrome/test/chromedriver/chrome/web_view.h
@@ -19,6 +19,7 @@ class TimeDelta;
class Value;
}
+class DevToolsClient;
struct Geoposition;
class JavaScriptDialogManager;
struct KeyEvent;
@@ -35,6 +36,9 @@ class WebView {
// Make DevToolsCient connect to DevTools if it is disconnected.
virtual Status ConnectIfNecessary() = 0;
+ // Return the DevToolsClient.
+ virtual DevToolsClient* GetDevToolsClient() = 0;
+
// Load a given URL in the main frame.
virtual Status Load(const std::string& url) = 0;
@@ -109,9 +113,6 @@ class WebView {
virtual Status IsPendingNavigation(
const std::string& frame_id, bool* is_pending) = 0;
- // Returns the frame id for the main frame.
- virtual Status GetMainFrame(std::string* out_frame) = 0;
-
// Returns the JavaScriptDialogManager. Never null.
virtual JavaScriptDialogManager* GetJavaScriptDialogManager() = 0;
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_web_view.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698