Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1535953003: Revert of Allow one-copy task tile worker pool to use compressed textures. (Closed)

Created:
5 years ago by Rick Byers
Modified:
5 years ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow one-copy task tile worker pool to use compressed textures. (patchset #14 id:260001 of https://codereview.chromium.org/1379783002/ ) Reason for revert: Causing perf bot failures - apparently triggers a render crash. http://crbug.com/570477 and possibly http://crbug.com/570809. Please run a perf tryjob including these tests before relanding. Original issue's description: > Allow one-copy and zero-copy task tile worker pools to use compressed textures. > > BUG=434699 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/7d60ce9a132a88ead407a2a58c91edc431e68259 > Cr-Commit-Position: refs/heads/master@{#364326} > > Committed: https://crrev.com/10fc39d36c0ba481056ec91a2984e02fd1127cf4 > Cr-Commit-Position: refs/heads/master@{#364484} TBR=reveman@chromium.org,nyquist@chromium.org,piman@chromium.org,sievers@chromium.org,christiank@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434699 Committed: https://crrev.com/77d1de5171d618b09032c71b13adf8bd6ce8cbed Cr-Commit-Position: refs/heads/master@{#366101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -251 lines) Patch
M blimp/client/compositor/blimp_layer_tree_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/base/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M cc/output/renderer_settings.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/output/renderer_settings.cc View 5 chunks +6 lines, -11 lines 0 comments Download
M cc/output/renderer_settings_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/proto/renderer_settings.proto View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 5 chunks +33 lines, -46 lines 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 4 chunks +27 lines, -52 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M cc/resources/platform_color.h View 1 chunk +1 line, -13 lines 0 comments Download
M cc/resources/resource_format.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/resources/resource_format.cc View 1 chunk +1 line, -23 lines 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 2 chunks +4 lines, -27 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Rick Byers
Created Revert of Allow one-copy task tile worker pool to use compressed textures.
5 years ago (2015-12-18 15:54:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535953003/1
5 years ago (2015-12-18 15:55:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 15:56:31 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-18 15:57:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77d1de5171d618b09032c71b13adf8bd6ce8cbed
Cr-Commit-Position: refs/heads/master@{#366101}

Powered by Google App Engine
This is Rietveld 408576698