Don't process messages sent to dead routing ids.

Don't process messages sent to dead routing ids.

BUG=556351, 445054
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/b78ba88705cb799426204d2ffd6b8cc558d0d3b7
Cr-Commit-Position: refs/heads/master@{#375685}

[ncarter (slow), 2015-12-18 06:21:14]

Description was changed from

==========
Don't process messages sent to dead routing ids.

BUG=
==========

to

==========
Don't process messages sent to dead routing ids.

BUG=556351, 445054
==========

[ncarter (slow), 2015-12-18 06:35:24]

nick@chromium.org changed reviewers:
+ nasko@chromium.org

[ncarter (slow), 2015-12-18 06:35:25]

Hi Nasko, 

Please have a look. I think this is the simplest way to do this.

[nasko, 2015-12-18 15:10:52]

Thanks for putting this one together! The checks look good, but the sanity
checker is hitting some failures.

https://codereview.chromium.org/1534933002/diff/60001/content/test/web_conten...
File content/test/web_contents_observer_sanity_checker.cc (left):

https://codereview.chromium.org/1534933002/diff/60001/content/test/web_conten...
content/test/web_contents_observer_sanity_checker.cc:321: // TODO(avi): Disabled
because of http://crbug.com/445054
Yay!

https://codereview.chromium.org/1534933002/diff/60001/content/test/web_conten...
File content/test/web_contents_observer_sanity_checker.cc (right):

https://codereview.chromium.org/1534933002/diff/60001/content/test/web_conten...
content/test/web_contents_observer_sanity_checker.cc:161:
AssertRenderFrameExists(render_frame_host->GetParent());
This is causing issues when process has died according to logs of failing tests,
since the parent is marked dead before the child.

[ncarter (slow), 2016-01-21 03:54:19]

nasko, I think this is ready for another round.

[nasko, 2016-01-21 17:50:19]

I have one question, but I'm ok if the code stays as it is.

LGTM

https://codereview.chromium.org/1534933002/diff/140001/content/test/test_rend...
File content/test/test_render_frame_host.cc (right):

https://codereview.chromium.org/1534933002/diff/140001/content/test/test_rend...
content/test/test_render_frame_host.cc:78:
render_view_host()->GetProcess()->Init();
Why do we need to call through render_view_host()? There is a GetProcess() on
the RFH and it should return the same one.

[ncarter (slow), 2016-01-26 23:08:22]

https://codereview.chromium.org/1534933002/diff/140001/content/test/test_rend...
File content/test/test_render_frame_host.cc (right):

https://codereview.chromium.org/1534933002/diff/140001/content/test/test_rend...
content/test/test_render_frame_host.cc:78:
render_view_host()->GetProcess()->Init();
On 2016/01/21 17:50:19, nasko wrote:
> Why do we need to call through render_view_host()? There is a GetProcess() on
> the RFH and it should return the same one.

Sure, but this is here to prevent a DCHECK failure in the RVH call on the line
below.

[ncarter (slow), 2016-01-26 23:08:29]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-01-26 23:12:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534933002/140001

[commit-bot: I haz the power, 2016-01-26 23:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 23:27:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ncarter (slow), 2016-01-27 00:45:10]

nick@chromium.org changed reviewers:
+ thestig@chromium.org

[ncarter (slow), 2016-01-27 00:45:10]

+thestig for chrome/ approval

[Lei Zhang, 2016-01-27 01:01:45]

On 2016/01/27 00:45:10, ncarter wrote:
> +thestig for chrome/ approval

If that's what git cl format likes, then lgtm

[ncarter (slow), 2016-01-27 17:48:41]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-01-27 17:49:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534933002/140001

[commit-bot: I haz the power, 2016-01-27 18:44:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 18:44:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2016-02-11 23:04:41]

Description was changed from

==========
Don't process messages sent to dead routing ids.

BUG=556351, 445054
==========

to

==========
Don't process messages sent to dead routing ids.

BUG=556351, 445054
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-02-11 23:04:57]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-11 23:08:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534933002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534933002/200001

[commit-bot: I haz the power, 2016-02-11 23:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 23:38:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[ncarter (slow), 2016-02-16 20:49:59]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-02-16 20:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1534933002/#ps220001
(title: "More unittest fixes.")

[commit-bot: I haz the power, 2016-02-16 20:51:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534933002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534933002/220001

[commit-bot: I haz the power, 2016-02-16 22:38:55]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-02-16 22:55:35]

Description was changed from

==========
Don't process messages sent to dead routing ids.

BUG=556351, 445054
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Don't process messages sent to dead routing ids.

BUG=556351, 445054
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/b78ba88705cb799426204d2ffd6b8cc558d0d3b7
Cr-Commit-Position: refs/heads/master@{#375685}
==========

[commit-bot: I haz the power, 2016-02-16 22:55:36]

Patchset 12 (id:??) landed as
https://crrev.com/b78ba88705cb799426204d2ffd6b8cc558d0d3b7
Cr-Commit-Position: refs/heads/master@{#375685}