Don't process messages sent to dead routing ids.

content/test/web_contents_observer_sanity_checker.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/web_contents_observer_sanity_checker.h"
 
 #include "base/strings/stringprintf.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/public/browser/navigation_handle.h"
@@ skipping 140 matching lines @@
   EnsureStableParentValue(render_frame_host);
 
   CHECK(!HasAnyChildren(render_frame_host))
       << "All children should be deleted before a frame is detached.";
 
   GlobalRoutingID routing_pair = GetRoutingPair(render_frame_host);
   CHECK(current_hosts_.erase(routing_pair))
       << "FrameDeleted called with a non-current RenderFrameHost.";
 
   if (render_frame_host->GetParent())
     AssertRenderFrameExists(render_frame_host->GetParent());

[nasko, 2015/12/18 15:10:51]

This is causing issues when process has died according to logs of failing tests,
since the parent is marked dead before the child.

 }
 
 void WebContentsObserverSanityChecker::DidStartNavigation(
     NavigationHandle* navigation_handle) {
   CHECK(!NavigationIsOngoing(navigation_handle));
 
   CHECK(navigation_handle->GetNetErrorCode() == net::OK);
   CHECK(!navigation_handle->HasCommitted());
   CHECK(!navigation_handle->IsErrorPage());
   CHECK_EQ(navigation_handle->GetWebContents(), web_contents());
@@ skipping 138 matching lines @@
                               active_media_players_.end());
 }
 
 bool WebContentsObserverSanityChecker::OnMessageReceived(
     const IPC::Message& message,
     RenderFrameHost* render_frame_host) {
   // FrameHostMsg_RenderProcessGone is special internal IPC message that
   // should not be leaking outside of RenderFrameHost.
   CHECK(message.type() != FrameHostMsg_RenderProcessGone::ID);
 
-#if !defined(OS_MACOSX)
-// TODO(avi): Disabled because of http://crbug.com/445054

[nasko, 2015/12/18 15:10:51]

Yay!

   AssertRenderFrameExists(render_frame_host);
-#endif
   return false;
 }
 
 void WebContentsObserverSanityChecker::WebContentsDestroyed() {
   CHECK(!web_contents_destroyed_);
   web_contents_destroyed_ = true;
   CHECK(ongoing_navigations_.empty());
   CHECK(active_media_players_.empty());
 }
 
 WebContentsObserverSanityChecker::WebContentsObserverSanityChecker(
     WebContents* web_contents)
     : WebContentsObserver(web_contents), web_contents_destroyed_(false) {
 }
 
 WebContentsObserverSanityChecker::~WebContentsObserverSanityChecker() {
   CHECK(web_contents_destroyed_);
 }
 
 void WebContentsObserverSanityChecker::AssertRenderFrameExists(
     RenderFrameHost* render_frame_host) {
   CHECK(!web_contents_destroyed_);
+  CHECK(render_frame_host->IsRenderFrameLive());
+
   GlobalRoutingID routing_pair = GetRoutingPair(render_frame_host);
 
   bool render_frame_created_happened = live_routes_.count(routing_pair) != 0;
   bool render_frame_deleted_happened = deleted_routes_.count(routing_pair) != 0;
 
   CHECK(render_frame_created_happened)
       << "A RenderFrameHost pointer was passed to a WebContentsObserver "
       << "method, but WebContentsObserver::RenderFrameCreated was never called "
       << "for that RenderFrameHost: " << Format(render_frame_host);
   CHECK(!render_frame_deleted_happened)
@@ skipping 43 matching lines @@
       if (live_routes_.count(entry.first))
         return true;
       if (current_hosts_.count(entry.first))
         return true;
     }
   }
   return false;
 }
 
 }  // namespace content