Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(254)

Issue 1682253006: Add a control group to the SiteIsolationExtensionsActive. It corresponds to the Disabled group of t… (Closed)

Created:
4 years ago by ncarter (slow)
Modified:
4 years ago
Reviewers:
Lei Zhang, Charlie Reis
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@uma3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a control group to the SiteIsolationExtensionsActive. "Control" corresponds to the Disabled group of the [non-synthetic] SiteIsolationExtensions field trial. In practice, our analysis has been skewed by the fact that SiteIsolationExtensionsActive/Default includes samples from populations where the SiteIsolationExtensions trial was not operative; these samples were a source of confounding variables. BUG=542921 Committed: https://crrev.com/1b39cd77e71f4c7d64e2ab4c1b0d3336f898514c Cr-Commit-Position: refs/heads/master@{#375027}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Set correct upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/site_details_browsertest.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
ncarter (slow)
charlie & lei, PTAL
4 years ago (2016-02-11 19:44:38 UTC) #2
Charlie Reis
Thanks, LGTM. This will let us exclude OOPIF-able users who aren't in the SiteIsolationExtensions trial ...
4 years ago (2016-02-11 21:19:01 UTC) #3
Charlie Reis
[+site-isolation-reviews for FYI]
4 years ago (2016-02-11 21:19:23 UTC) #4
Lei Zhang
lgtm
4 years ago (2016-02-11 21:26:48 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1693583003 Patch 1). Please resolve the dependency and ...
4 years ago (2016-02-11 21:34:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682253006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682253006/40001
4 years ago (2016-02-11 22:54:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-02-11 23:08:31 UTC) #11
commit-bot: I haz the power
4 years ago (2016-02-16 22:39:10 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b39cd77e71f4c7d64e2ab4c1b0d3336f898514c
Cr-Commit-Position: refs/heads/master@{#375027}

Powered by Google App Engine
This is Rietveld 408576698