Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 1534933002: Don't process messages sent to dead routing ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More unittest fixes. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/test_render_frame_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index 8ac2dd0f199b84158997e211d665083696d95ce3..24b8ac945d9f258084c9f1923390a4d4c8a1312b 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -317,11 +317,9 @@ bool WebContentsObserverSanityChecker::OnMessageReceived(
// FrameHostMsg_RenderProcessGone is special internal IPC message that
// should not be leaking outside of RenderFrameHost.
CHECK(message.type() != FrameHostMsg_RenderProcessGone::ID);
+ CHECK(render_frame_host->IsRenderFrameLive());
-#if !defined(OS_MACOSX)
-// TODO(avi): Disabled because of http://crbug.com/445054
AssertRenderFrameExists(render_frame_host);
-#endif
return false;
}
« no previous file with comments | « content/test/test_render_frame_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698