Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: remoting/protocol/monitored_video_stub_unittest.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/monitored_video_stub_unittest.cc
diff --git a/remoting/protocol/monitored_video_stub_unittest.cc b/remoting/protocol/monitored_video_stub_unittest.cc
index 58db106521fa677f8560b71d92042ecf888ba6ff..300552b9f73f03d306d3989ee986e1aae781b80e 100644
--- a/remoting/protocol/monitored_video_stub_unittest.cc
+++ b/remoting/protocol/monitored_video_stub_unittest.cc
@@ -50,13 +50,13 @@ TEST_F(MonitoredVideoStubTest, OnChannelConnected) {
// finishes, so we expect to see at most one transition to not ready.
EXPECT_CALL(*this, OnVideoChannelStatus(false)).Times(AtMost(1));
- monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
+ monitor_->ProcessVideoPacket(std::move(packet_), base::Closure());
base::RunLoop().RunUntilIdle();
}
TEST_F(MonitoredVideoStubTest, OnChannelDisconnected) {
EXPECT_CALL(*this, OnVideoChannelStatus(true));
- monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
+ monitor_->ProcessVideoPacket(std::move(packet_), base::Closure());
EXPECT_CALL(*this, OnVideoChannelStatus(false))
.WillOnce(
@@ -72,8 +72,8 @@ TEST_F(MonitoredVideoStubTest, OnChannelStayConnected) {
// finishes, so we expect to see at most one transition to not ready.
EXPECT_CALL(*this, OnVideoChannelStatus(false)).Times(AtMost(1));
- monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
- monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
+ monitor_->ProcessVideoPacket(std::move(packet_), base::Closure());
+ monitor_->ProcessVideoPacket(std::move(packet_), base::Closure());
base::RunLoop().RunUntilIdle();
}
@@ -82,7 +82,7 @@ TEST_F(MonitoredVideoStubTest, OnChannelStayDisconnected) {
EXPECT_CALL(*this, OnVideoChannelStatus(true)).Times(1);
EXPECT_CALL(*this, OnVideoChannelStatus(false)).Times(1);
- monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
+ monitor_->ProcessVideoPacket(std::move(packet_), base::Closure());
message_loop_.PostDelayedTask(
FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

Powered by Google App Engine
This is Rietveld 408576698