Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: remoting/protocol/me2me_host_authenticator_factory.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/me2me_host_authenticator_factory.cc
diff --git a/remoting/protocol/me2me_host_authenticator_factory.cc b/remoting/protocol/me2me_host_authenticator_factory.cc
index 59267083edb670db6741d8d5b4ec622657cc1653..011ee5f3a004bc186c1680f86ff4ccd822bf5ce3 100644
--- a/remoting/protocol/me2me_host_authenticator_factory.cc
+++ b/remoting/protocol/me2me_host_authenticator_factory.cc
@@ -81,7 +81,7 @@ Me2MeHostAuthenticatorFactory::CreateWithSharedSecret(
result->key_pair_ = key_pair;
result->shared_secret_hash_ = shared_secret_hash;
result->pairing_registry_ = pairing_registry;
- return result.Pass();
+ return std::move(result);
Jamie 2015/12/22 12:23:36 Unnecessary?
Sergey Ulanov 2015/12/22 18:07:35 Necessary because upcasting.
}
@@ -100,8 +100,8 @@ Me2MeHostAuthenticatorFactory::CreateWithThirdPartyAuth(
result->host_owner_ = host_owner;
result->local_cert_ = local_cert;
result->key_pair_ = key_pair;
- result->token_validator_factory_ = token_validator_factory.Pass();
- return result.Pass();
+ result->token_validator_factory_ = std::move(token_validator_factory);
+ return std::move(result);
Jamie 2015/12/22 12:23:36 Unnecessary?
Sergey Ulanov 2015/12/22 18:07:35 Necessary because upcasting.
}
Me2MeHostAuthenticatorFactory::Me2MeHostAuthenticatorFactory() {

Powered by Google App Engine
This is Rietveld 408576698