remoting/protocol/negotiating_authenticator_base.cc - Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/negotiating_authenticator_base.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/negotiating_authenticator_base.cc

diff --git a/remoting/protocol/negotiating_authenticator_base.cc b/remoting/protocol/negotiating_authenticator_base.cc

index c9d4b2acb81940157bc2525c464769afd8c5f2fd..12e1d8b5bf12a87f88133daf0b5e7b6c83721856 100644

--- a/remoting/protocol/negotiating_authenticator_base.cc

+++ b/remoting/protocol/negotiating_authenticator_base.cc

@@ -94,7 +94,7 @@ NegotiatingAuthenticatorBase::GetNextMessageInternal() {

state_ = current_authenticator_->state();

DCHECK(state_ == ACCEPTED || state_ == WAITING_MESSAGE);

result->AddAttr(kMethodAttributeQName, current_method_.ToString());

- return result.Pass();

+ return result;

}

void NegotiatingAuthenticatorBase::AddMethod(