CC Animations: Port UI Browser Compositor to use compositor animation timelines.

CC Animations: Port UI Browser Compositor to use compositor animation timelines.

Use AnimationPlayer to add animations if new system enabled.

BUG=394777
Committed: https://crrev.com/841229008127b97e727169e57d3d71d10f1a1428
Cr-Commit-Position: refs/heads/master@{#366360}

[loyso (OOO), 2015-12-17 05:22:53]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, piman@chromium.org, vollick@chromium.org

[loyso (OOO), 2015-12-17 05:22:53]

ajuma@chromium.org: Please review changes in 

vollick@chromium.org: Please review changes in 

piman@chromium.org: Please review changes in

[piman, 2015-12-17 05:37:28]

https://codereview.chromium.org/1533643003/diff/1/ui/compositor/layer_animato...
File ui/compositor/layer_animator.cc (right):

https://codereview.chromium.org/1533643003/diff/1/ui/compositor/layer_animato...
ui/compositor/layer_animator.cc:54: if
(Layer::UILayerSettings().use_compositor_animation_timelines)
nit: needs {}

[piman, 2015-12-17 05:37:37]

lgtm

[Ian Vollick, 2015-12-17 05:53:23]

On 2015/12/17 05:37:37, piman (in KST timezone) wrote:
> lgtm

lgtm.

[loyso (OOO), 2015-12-17 05:53:53]

https://codereview.chromium.org/1533643003/diff/1/ui/compositor/layer_animato...
File ui/compositor/layer_animator.cc (right):

https://codereview.chromium.org/1533643003/diff/1/ui/compositor/layer_animato...
ui/compositor/layer_animator.cc:54: if
(Layer::UILayerSettings().use_compositor_animation_timelines)
On 2015/12/17 05:37:28, piman (in KST timezone) wrote:
> nit: needs {}

Done.

https://codereview.chromium.org/1533643003/diff/1/ui/compositor/layer_animato...
ui/compositor/layer_animator.cc:125: SwitchToLayer(delegate ?
delegate->GetCcLayer() : nullptr);
I'll move this fix to the base "depends on" CL.

[loyso (OOO), 2015-12-18 03:56:19]

Looks like it causes problems with
WebContentsViewAuraTest.RepeatedQuickOverscrollGestures in the dependent CL (if
new mode enabled).
Investigating.

[loyso (OOO), 2015-12-18 04:28:47]

On 2015/12/18 03:56:19, loyso wrote:
> Looks like it causes problems with
> WebContentsViewAuraTest.RepeatedQuickOverscrollGestures in the dependent CL
(if
> new mode enabled).
> Investigating.

Both WebContentsViewAuraTest.OverscrollScreenshot and
WebContentsViewAuraTest.RepeatedQuickOverscrollGestures are flaky and disabled
for specific platforms.
I will double check it, anyway.

[loyso (OOO), 2015-12-21 04:13:00]

The fix: https://codereview.chromium.org/1539233002

[loyso (OOO), 2015-12-21 09:55:35]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2015-12-21 09:55:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1533643003/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-12-21 09:55:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533643003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533643003/80001

[commit-bot: I haz the power, 2015-12-21 10:03:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-21 10:04:44]

Description was changed from

==========
CC Animations: Port UI Browser Compositor to use compositor animation timelines.

Use AnimationPlayer to add animations if new system enabled.

BUG=394777
==========

to

==========
CC Animations: Port UI Browser Compositor to use compositor animation timelines.

Use AnimationPlayer to add animations if new system enabled.

BUG=394777

Committed: https://crrev.com/841229008127b97e727169e57d3d71d10f1a1428
Cr-Commit-Position: refs/heads/master@{#366360}
==========

[commit-bot: I haz the power, 2015-12-21 10:04:44]

Patchset 5 (id:??) landed as
https://crrev.com/841229008127b97e727169e57d3d71d10f1a1428
Cr-Commit-Position: refs/heads/master@{#366360}