Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1539233002: CC Animations: Fix the case when main-thread player changes layer_id. (Closed)

Created:
5 years ago by loyso (OOO)
Modified:
5 years ago
Reviewers:
Ian Vollick, ajuma, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Fix the case when main-thread player changes layer_id. We didn't compare layer ids. BUG=394777 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e4e0bcc0f7cc2ba281200c7d1907c64fba9d4f3e Cr-Commit-Position: refs/heads/master@{#366338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -9 lines) Patch
M cc/animation/animation_player.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 2 chunks +5 lines, -1 line 0 comments Download
M cc/test/animation_timelines_test_common.cc View 2 chunks +8 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
loyso (OOO)
5 years ago (2015-12-21 04:09:58 UTC) #3
loyso (OOO)
Review, anyone? This is urgent.
5 years ago (2015-12-21 05:15:58 UTC) #7
Ian Vollick
On 2015/12/21 05:15:58, loyso wrote: > Review, anyone? This is urgent. lgtm.
5 years ago (2015-12-21 06:31:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539233002/1
5 years ago (2015-12-21 06:33:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 06:37:32 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-21 06:38:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4e0bcc0f7cc2ba281200c7d1907c64fba9d4f3e
Cr-Commit-Position: refs/heads/master@{#366338}

Powered by Google App Engine
This is Rietveld 408576698