Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1536833004: CC Animations: Enable external animation host for ui::Compositor (Aura) (Closed)

Created:
5 years ago by loyso (OOO)
Modified:
5 years ago
Reviewers:
Ian Vollick, ajuma, piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@player2animator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Enable external animation host for ui::Compositor (Aura). This is the only compositor which blocks us from deleting the old system. BUG=394777 Committed: https://crrev.com/4cc0ad4edc16a274a4b403c9ac1c07ef86624b0c Cr-Commit-Position: refs/heads/master@{#366487}

Patch Set 1 #

Patch Set 2 : Fix chrome_restart_request.cc compilation. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/compositor/test/test_suite.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
loyso (OOO)
5 years ago (2015-12-18 02:59:56 UTC) #3
piman
lgtm
5 years ago (2015-12-18 06:43:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536833004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536833004/60001
5 years ago (2015-12-21 23:24:22 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-21 23:34:15 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-21 23:35:08 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4cc0ad4edc16a274a4b403c9ac1c07ef86624b0c
Cr-Commit-Position: refs/heads/master@{#366487}

Powered by Google App Engine
This is Rietveld 408576698