Chromium Code Reviews| Index: chrome/browser/translate/translate_manager_metrics.cc |
| diff --git a/chrome/browser/translate/translate_manager_metrics.cc b/chrome/browser/translate/translate_manager_metrics.cc |
| index 5b11d30548b4e0b698074cad0e3ff7a83357eff0..b5a81f80944dc0560b1c2191a6eee46657005c12 100644 |
| --- a/chrome/browser/translate/translate_manager_metrics.cc |
| +++ b/chrome/browser/translate/translate_manager_metrics.cc |
| @@ -4,8 +4,12 @@ |
| #include "chrome/browser/translate/translate_manager_metrics.h" |
| +#include <string> |
| + |
| #include "base/basictypes.h" |
| #include "base/metrics/histogram.h" |
| +#include "base/metrics/sparse_histogram.h" |
| +#include "chrome/common/metrics/metrics_util.h" |
| namespace { |
| @@ -17,6 +21,10 @@ const char kTranslateReportLanguageDetectionError[] = |
| "Translate.ReportLanguageDetectionError"; |
| const char kTranslateServerReportedUnsupportedLanguage[] = |
|
Takashi Toyoshima
2013/05/21 11:11:43
Remove value for the obsoleted UMA.
hajimehoshi
2013/05/22 04:19:27
Done.
|
| "Translate.ServerReportedUnsupportedLanguage"; |
| +const char kTranslateUnavailableLanguage[] = |
| + "Translate.UnavailableLanguage"; |
| +const char kTranslateUnsupportedLanguageAtInitiation[] = |
| + "Translate.UnsupportedLanguageAtInitiation"; |
| struct MetricsEntry { |
| TranslateManagerMetrics::MetricsNameIndex index; |
| @@ -31,6 +39,10 @@ const MetricsEntry kMetricsEntries[] = { |
| kTranslateReportLanguageDetectionError }, |
| { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, |
|
Takashi Toyoshima
2013/05/21 11:11:43
remove obsoleted one.
hajimehoshi
2013/05/22 04:19:27
Done.
|
| kTranslateServerReportedUnsupportedLanguage }, |
| + { TranslateManagerMetrics::UMA_UNAVAILABLE_LANGUAGE, |
| + kTranslateUnavailableLanguage }, |
| + { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION, |
| + kTranslateUnsupportedLanguageAtInitiation }, |
| }; |
| COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX, |
| @@ -50,8 +62,16 @@ void ReportLanguageDetectionError() { |
| UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1); |
| } |
| -void ReportUnsupportedLanguage() { |
| - UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1); |
| +void ReportUnavailableLanguage(const std::string& language) { |
| + int language_code = metrics::ToLanguageCode(language); |
| + UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnavailableLanguage, |
| + language_code); |
| +} |
| + |
| +void ReportUnsupportedLanguageAtInitiation(const std::string& language) { |
| + int language_code = metrics::ToLanguageCode(language); |
| + UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation, |
| + language_code); |
| } |
| const char* GetMetricsName(MetricsNameIndex index) { |