Chromium Code Reviews| Index: chrome/browser/translate/translate_manager_metrics.h |
| diff --git a/chrome/browser/translate/translate_manager_metrics.h b/chrome/browser/translate/translate_manager_metrics.h |
| index f037cfe55d5b5712133a64343e231287697250e3..91dbcf37b4ba906f7a4360664a164d30ef6c82f0 100644 |
| --- a/chrome/browser/translate/translate_manager_metrics.h |
| +++ b/chrome/browser/translate/translate_manager_metrics.h |
| @@ -5,6 +5,8 @@ |
| #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_MANAGER_METRICS_H_ |
| #define CHROME_BROWSER_TRANSLATE_TRANSLATE_MANAGER_METRICS_H_ |
| +#include <string> |
| + |
| namespace TranslateManagerMetrics { |
| // An indexing type to query each UMA entry name via GetMetricsName() function. |
| @@ -12,7 +14,9 @@ namespace TranslateManagerMetrics { |
| enum MetricsNameIndex { |
| UMA_INITIATION_STATUS, |
| UMA_LANGUAGE_DETECTION_ERROR, |
| - UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, |
| + UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, // obsolete |
|
Takashi Toyoshima
2013/05/21 11:11:43
Remove obsoleted enum ID.
It's ok to reuse the sam
hajimehoshi
2013/05/22 04:19:27
Done.
|
| + UMA_UNAVAILABLE_LANGUAGE, |
| + UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION, |
| UMA_MAX, |
| }; |
| @@ -42,7 +46,10 @@ void ReportInitiationStatus(InitiationStatusType type); |
| void ReportLanguageDetectionError(); |
| // Called when it turns out that translating page is in unsupported language. |
| -void ReportUnsupportedLanguage(); |
| +// |language| is a language code of ISO 639. |
| +void ReportUnavailableLanguage(const std::string& language); |
| + |
| +void ReportUnsupportedLanguageAtInitiation(const std::string& language); |
| // Provides UMA entry names for unit tests. |
| const char* GetMetricsName(MetricsNameIndex index); |