Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/translate/translate_manager_metrics.cc

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_manager_metrics.h" 5 #include "chrome/browser/translate/translate_manager_metrics.h"
6 6
7 #include <string>
8
7 #include "base/basictypes.h" 9 #include "base/basictypes.h"
8 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/metrics/sparse_histogram.h"
12 #include "chrome/common/metrics/metrics_util.h"
9 13
10 namespace { 14 namespace {
11 15
12 // Constant string values to indicate UMA names. All entries should have 16 // Constant string values to indicate UMA names. All entries should have
13 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|. 17 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
14 const char kTranslateInitiationStatus[] = 18 const char kTranslateInitiationStatus[] =
15 "Translate.InitiationStatus"; 19 "Translate.InitiationStatus";
16 const char kTranslateReportLanguageDetectionError[] = 20 const char kTranslateReportLanguageDetectionError[] =
17 "Translate.ReportLanguageDetectionError"; 21 "Translate.ReportLanguageDetectionError";
18 const char kTranslateServerReportedUnsupportedLanguage[] = 22 const char kTranslateServerReportedUnsupportedLanguage[] =
Takashi Toyoshima 2013/05/21 11:11:43 Remove value for the obsoleted UMA.
hajimehoshi 2013/05/22 04:19:27 Done.
19 "Translate.ServerReportedUnsupportedLanguage"; 23 "Translate.ServerReportedUnsupportedLanguage";
24 const char kTranslateUnavailableLanguage[] =
25 "Translate.UnavailableLanguage";
26 const char kTranslateUnsupportedLanguageAtInitiation[] =
27 "Translate.UnsupportedLanguageAtInitiation";
20 28
21 struct MetricsEntry { 29 struct MetricsEntry {
22 TranslateManagerMetrics::MetricsNameIndex index; 30 TranslateManagerMetrics::MetricsNameIndex index;
23 const char* const name; 31 const char* const name;
24 }; 32 };
25 33
26 // This entry table should be updated when new UMA items are added. 34 // This entry table should be updated when new UMA items are added.
27 const MetricsEntry kMetricsEntries[] = { 35 const MetricsEntry kMetricsEntries[] = {
28 { TranslateManagerMetrics::UMA_INITIATION_STATUS, 36 { TranslateManagerMetrics::UMA_INITIATION_STATUS,
29 kTranslateInitiationStatus }, 37 kTranslateInitiationStatus },
30 { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR, 38 { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR,
31 kTranslateReportLanguageDetectionError }, 39 kTranslateReportLanguageDetectionError },
32 { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, 40 { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
Takashi Toyoshima 2013/05/21 11:11:43 remove obsoleted one.
hajimehoshi 2013/05/22 04:19:27 Done.
33 kTranslateServerReportedUnsupportedLanguage }, 41 kTranslateServerReportedUnsupportedLanguage },
42 { TranslateManagerMetrics::UMA_UNAVAILABLE_LANGUAGE,
43 kTranslateUnavailableLanguage },
44 { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
45 kTranslateUnsupportedLanguageAtInitiation },
34 }; 46 };
35 47
36 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX, 48 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
37 arraysize_of_kMetricsEntries_should_be_UMA_MAX); 49 arraysize_of_kMetricsEntries_should_be_UMA_MAX);
38 50
39 } // namespace 51 } // namespace
40 52
41 namespace TranslateManagerMetrics { 53 namespace TranslateManagerMetrics {
42 54
43 void ReportInitiationStatus(InitiationStatusType type) { 55 void ReportInitiationStatus(InitiationStatusType type) {
44 UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus, 56 UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus,
45 type, 57 type,
46 INITIATION_STATUS_MAX); 58 INITIATION_STATUS_MAX);
47 } 59 }
48 60
49 void ReportLanguageDetectionError() { 61 void ReportLanguageDetectionError() {
50 UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1); 62 UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1);
51 } 63 }
52 64
53 void ReportUnsupportedLanguage() { 65 void ReportUnavailableLanguage(const std::string& language) {
54 UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1); 66 int language_code = metrics::ToLanguageCode(language);
67 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnavailableLanguage,
68 language_code);
69 }
70
71 void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
72 int language_code = metrics::ToLanguageCode(language);
73 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation,
74 language_code);
55 } 75 }
56 76
57 const char* GetMetricsName(MetricsNameIndex index) { 77 const char* GetMetricsName(MetricsNameIndex index) {
58 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) { 78 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
59 if (kMetricsEntries[i].index == index) 79 if (kMetricsEntries[i].index == index)
60 return kMetricsEntries[i].name; 80 return kMetricsEntries[i].name;
61 } 81 }
62 NOTREACHED(); 82 NOTREACHED();
63 return NULL; 83 return NULL;
64 } 84 }
65 85
66 } // namespace TranslateManagerMetrics 86 } // namespace TranslateManagerMetrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698