Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2894)

Unified Diff: chrome/browser/translate/translate_manager_metrics_unittest.cc

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager_metrics_unittest.cc
diff --git a/chrome/browser/translate/translate_manager_metrics_unittest.cc b/chrome/browser/translate/translate_manager_metrics_unittest.cc
index 91b66aecc2e3c3cbacd809b841c7dca1bba663b8..562c85a50c85cdaa91a9bdd05247af9452581158 100644
--- a/chrome/browser/translate/translate_manager_metrics_unittest.cc
+++ b/chrome/browser/translate/translate_manager_metrics_unittest.cc
@@ -146,10 +146,18 @@ TEST(TranslateManagerMetricsTest, ReportLanguageDetectionError) {
EXPECT_EQ(1, recorder.GetTotalCount());
}
-TEST(TranslateManagerMetricsTest, ReportedUnsupportedLanguage) {
+TEST(TranslateManagerMetricsTest, ReportedUnavailableLanguage) {
MetricsRecorder recorder(TranslateManagerMetrics::GetMetricsName(
- TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE));
+ TranslateManagerMetrics::UMA_UNAVAILABLE_LANGUAGE));
EXPECT_EQ(0, recorder.GetTotalCount());
- TranslateManagerMetrics::ReportUnsupportedLanguage();
+ TranslateManagerMetrics::ReportUnavailableLanguage("en");
+ EXPECT_EQ(1, recorder.GetTotalCount());
Takashi Toyoshima 2013/05/21 11:11:43 Can we check a reported value for "en"?
hajimehoshi 2013/05/22 04:19:27 Done.
+}
+
+TEST(TranslateManagerMetricsTest, ReportedUnsupportedLanguageAtInitiation) {
+ MetricsRecorder recorder(TranslateManagerMetrics::GetMetricsName(
+ TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION));
+ EXPECT_EQ(0, recorder.GetTotalCount());
+ TranslateManagerMetrics::ReportUnsupportedLanguageAtInitiation("en");
EXPECT_EQ(1, recorder.GetTotalCount());
Takashi Toyoshima 2013/05/21 11:11:43 ditto.
hajimehoshi 2013/05/22 04:19:27 Done.
}

Powered by Google App Engine
This is Rietveld 408576698