Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530203002: Reland of move drawSprite from canvas (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of move drawSprite from canvas (patchset #1 id:1 of https://codereview.chromium.org/1529803004/ ) Reason for revert: guard has landed in chrome Original issue's description: > Revert of remove drawSprite from canvas (patchset #4 id:60001 of https://codereview.chromium.org/1534443003/ ) > > Reason for revert: > need to remove an override in chrome > > Original issue's description: > > remove drawSprite from canvas > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/4657ce2324ea197507c4ba728d81138f56da13b1 > > TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/32704674f64cb6a14356dfebe060cd3484c06cc7 TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/da420b976e61071cfe5de10556b4b23e519091d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -575 lines) Patch
M bench/ImageBench.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 2 chunks +1 line, -24 lines 0 comments Download
M gm/imagefiltersbase.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M gm/imagefilterscropped.cpp View 2 chunks +1 line, -24 lines 0 comments Download
M gm/spritebitmap.cpp View 5 chunks +6 lines, -180 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +3 lines, -14 lines 0 comments Download
M include/private/SkRecords.h View 2 chunks +0 lines, -6 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkLuaCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkPaintFilterCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +1 line, -36 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/SkPaintFilterCanvas.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 2 chunks +0 lines, -31 lines 0 comments Download
M tests/ImageFilterTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Reland of move drawSprite from canvas
5 years ago (2015-12-16 16:37:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530203002/1
5 years ago (2015-12-16 16:38:05 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-16 16:38:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/da420b976e61071cfe5de10556b4b23e519091d6

Powered by Google App Engine
This is Rietveld 408576698