Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529803004: Revert of remove drawSprite from canvas (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of remove drawSprite from canvas (patchset #4 id:60001 of https://codereview.chromium.org/1534443003/ ) Reason for revert: need to remove an override in chrome Original issue's description: > remove drawSprite from canvas > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4657ce2324ea197507c4ba728d81138f56da13b1 TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/32704674f64cb6a14356dfebe060cd3484c06cc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -23 lines) Patch
M bench/ImageBench.cpp View 1 chunk +114 lines, -0 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 2 chunks +24 lines, -1 line 0 comments Download
M gm/imagefiltersbase.cpp View 2 chunks +21 lines, -0 lines 0 comments Download
M gm/imagefilterscropped.cpp View 2 chunks +24 lines, -1 line 0 comments Download
M gm/spritebitmap.cpp View 5 chunks +180 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +14 lines, -3 lines 0 comments Download
M include/private/SkRecords.h View 2 chunks +6 lines, -0 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkPaintFilterCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +36 lines, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/utils/SkPaintFilterCanvas.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
reed1
Created Revert of remove drawSprite from canvas
5 years ago (2015-12-16 16:26:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529803004/1
5 years ago (2015-12-16 16:26:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/32704674f64cb6a14356dfebe060cd3484c06cc7
5 years ago (2015-12-16 16:27:13 UTC) #4
reed1
5 years ago (2015-12-16 16:37:52 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1530203002/ by reed@google.com.

The reason for reverting is: guard has landed in chrome.

Powered by Google App Engine
This is Rietveld 408576698