Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc (Closed)

Created:
5 years ago by Mark Mentovai
Modified:
5 years ago
Reviewers:
Robert Sesek, scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc 7764fa114486 Remove errant double-semicolons 72d6be5cb9d9 win: Fix debug iterator failure on empty database read/write d81d83661def package.h: Update version number to 0.8.0 5be8ce4ea0fe Get module versions and types from in-memory images 384fd93d6d70 win: Add a VSFixedFileInfo test to check all modules 894a06070e31 win: Fix some warnings reported by /analyze 47fbac4ae105 win: Placate more OS versions in the PEImageReader test fabcd790578e Add missing comma in compat.gyp f55d18ade687 Add AlignedVector and use it for vector<MEMORY_BASIC_INFORMATION64> 7efdc94f5982 Fixes for Chromium checkperms.py PRESUBMIT b9e732d3180f win: Fix a few sign mismatch warnings in crashpad e9a843c626b2 win: Set shutdown order to make the handler shutdown as late as possible a33736dd0d60 Fix AlignedAllocator for pre-C++11 libraries 8f3b0af2154a client: Depend on compat 583d1dc3efa9 Provide std::move() in compat instead of using crashpad::move() BUG=427616, 472900, 564691, 567877 R=rsesek@chromium.org TBR=scottmg@chromium.org Committed: https://crrev.com/00b373d8751272bac2ec1f3432ec4cbba740a43d Cr-Commit-Position: refs/heads/master@{#365061}

Patch Set 1 #

Patch Set 2 : Fix GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1824 lines, -500 lines) Patch
M build/secondary/third_party/crashpad/crashpad/compat/BUILD.gn View 1 2 chunks +6 lines, -1 line 0 comments Download
M build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/README.chromium View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/client/client.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_test.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_win.cc View 5 chunks +26 lines, -19 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_mac.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/client/settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/compat/compat.gyp View 2 chunks +5 lines, -1 line 0 comments Download
A + third_party/crashpad/crashpad/compat/non_cxx11_lib/type_traits View 1 chunk +18 lines, -12 lines 0 comments Download
A third_party/crashpad/crashpad/compat/non_cxx11_lib/utility View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/handler/mac/exception_handler_server.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer_test.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_exception_writer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc View 8 chunks +12 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_misc_info_writer_test.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer_test.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_writer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_writer_test.cc View 10 chunks +22 lines, -21 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_string_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_system_info_writer_test.cc View 9 chunks +8 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc View 12 chunks +26 lines, -26 lines 0 comments Download
M third_party/crashpad/crashpad/package.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/snapshot.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/test/test_process_snapshot.h View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/test/test_thread_snapshot.h View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader.h View 6 chunks +46 lines, -29 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader.cc View 10 chunks +166 lines, -93 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader_test.cc View 4 chunks +112 lines, -5 lines 0 comments Download
A third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.h View 1 chunk +179 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc View 1 chunk +279 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/snapshot/win/process_subrange_reader.h View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/snapshot/win/process_subrange_reader.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/system_snapshot_win.cc View 1 chunk +26 lines, -24 lines 0 comments Download
M third_party/crashpad/crashpad/test/mac/mach_multiprocess.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/win/win_child_process.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/tools/crashpad_database_util.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_handshake.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_handshake.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/task_memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_transport.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_transport_test.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_address_range.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_address_range.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/stdlib/aligned_allocator.h View 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/stdlib/aligned_allocator.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/stdlib/aligned_allocator_test.cc View 1 chunk +117 lines, -0 lines 0 comments Download
D third_party/crashpad/crashpad/util/stdlib/move.h View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/util_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/exception_handler_server.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/module_version.h View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info.h View 5 chunks +20 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info_test.cc View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Mark Mentovai
5 years ago (2015-12-14 15:44:00 UTC) #2
Robert Sesek
lgtm
5 years ago (2015-12-14 15:46:47 UTC) #3
Mark Mentovai
+scottmg for gn fixes in build.
5 years ago (2015-12-14 17:30:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529483002/20001
5 years ago (2015-12-14 18:04:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 19:18:09 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-14 19:19:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00b373d8751272bac2ec1f3432ec4cbba740a43d
Cr-Commit-Position: refs/heads/master@{#365061}

Powered by Google App Engine
This is Rietveld 408576698