third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc - Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc

Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/test/test_thread_snapshot.h ('k') | third_party/crashpad/crashpad/snapshot/win/pe_image_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc b/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc

index 49478880f8432fa7c194c824bce3482100ff4f9a..0553f35b1affb55be510ecfed54f785c20158aa8 100644

--- a/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.cc

@@ -19,7 +19,6 @@

#include "snapshot/win/pe_image_reader.h"

#include "util/misc/tri_state.h"

#include "util/misc/uuid.h"

-#include "util/win/module_version.h"

namespace crashpad {

namespace internal {

@@ -210,7 +209,7 @@ const VS_FIXEDFILEINFO* ModuleSnapshotWin::VSFixedFileInfo() const {

if (initialized_vs_fixed_file_info_.is_uninitialized()) {

initialized_vs_fixed_file_info_.set_invalid();

- if (GetModuleVersionAndType(base::FilePath(name_), &vs_fixed_file_info_)) {

+ if (pe_image_reader_->VSFixedFileInfo(&vs_fixed_file_info_)) {

initialized_vs_fixed_file_info_.set_valid();

}