third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc - Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc

Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc ('k') | third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc b/third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc

index 1c9b2858e401e1b1a0928656c37beb9d076680bf..352865567fdcbb5322011abf40d561b22243bff3 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc

@@ -14,11 +14,12 @@

#include "minidump/minidump_memory_writer.h"

+#include <utility>

#include "base/auto_reset.h"

#include "base/logging.h"

#include "snapshot/memory_snapshot.h"

#include "util/file/file_writer.h"

-#include "util/stdlib/move.h"

#include "util/numeric/safe_assignment.h"

namespace crashpad {

@@ -178,7 +179,7 @@ void MinidumpMemoryListWriter::AddFromSnapshot(

for (const MemorySnapshot* memory_snapshot : memory_snapshots) {

scoped_ptr<MinidumpMemoryWriter> memory =

MinidumpMemoryWriter::CreateFromSnapshot(memory_snapshot);

- AddMemory(crashpad::move(memory));

+ AddMemory(std::move(memory));

}