third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc - Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc

Issue 1529483002: Update Crashpad to 583d1dc3efa96ea50f62afa69a598eeed1534edc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc ('k') | third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc

index a1073f8373d42a8d3efba658a43d36c3af1b535b..f59cbb85ebda9ab24efbbbe8ec6ab2a44d911896 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc

@@ -15,6 +15,7 @@

#include "minidump/minidump_memory_info_writer.h"

#include <string>

+#include <utility>

#include "gtest/gtest.h"

#include "minidump/minidump_file_writer.h"

@@ -22,7 +23,6 @@

#include "minidump/test/minidump_writable_test_util.h"

#include "snapshot/test/test_memory_map_region_snapshot.h"

#include "util/file/string_file.h"

-#include "util/stdlib/move.h"

namespace crashpad {

namespace test {

@@ -59,7 +59,7 @@ TEST(MinidumpMemoryInfoWriter, Empty) {

MinidumpFileWriter minidump_file_writer;

auto memory_info_list_writer =

make_scoped_ptr(new MinidumpMemoryInfoListWriter());

- minidump_file_writer.AddStream(crashpad::move(memory_info_list_writer));

+ minidump_file_writer.AddStream(std::move(memory_info_list_writer));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));

@@ -96,7 +96,7 @@ TEST(MinidumpMemoryInfoWriter, OneRegion) {

memory_map.push_back(memory_map_region.get());

memory_info_list_writer->InitializeFromSnapshot(memory_map);

- minidump_file_writer.AddStream(crashpad::move(memory_info_list_writer));

+ minidump_file_writer.AddStream(std::move(memory_info_list_writer));

StringFile string_file;

ASSERT_TRUE(minidump_file_writer.WriteEverything(&string_file));