Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 152923006: Fix for a smi stores optimization on x64 with a test case. (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix for a smi stores optimization on x64 with a test case. BUG=338425 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/smi-stores-opt.js View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-11 15:17:16 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-11 15:47:03 UTC) #2
Igor Sheludko
6 years, 10 months ago (2014-02-11 16:02:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698