Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 152923006: Fix for a smi stores optimization on x64 with a test case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/mjsunit/compiler/smi-stores-opt.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3911 matching lines...) Expand 10 before | Expand all | Expand 10 after
3922 3922
3923 Register write_register = object; 3923 Register write_register = object;
3924 if (!access.IsInobject()) { 3924 if (!access.IsInobject()) {
3925 write_register = ToRegister(instr->temp()); 3925 write_register = ToRegister(instr->temp());
3926 __ movp(write_register, FieldOperand(object, JSObject::kPropertiesOffset)); 3926 __ movp(write_register, FieldOperand(object, JSObject::kPropertiesOffset));
3927 } 3927 }
3928 3928
3929 if (representation.IsSmi() && 3929 if (representation.IsSmi() &&
3930 hinstr->value()->representation().IsInteger32()) { 3930 hinstr->value()->representation().IsInteger32()) {
3931 ASSERT(hinstr->store_mode() == STORE_TO_INITIALIZED_ENTRY); 3931 ASSERT(hinstr->store_mode() == STORE_TO_INITIALIZED_ENTRY);
3932 #ifdef DEBUG
3933 __ movq(kScratchRegister, FieldOperand(write_register, offset));
3934 __ AssertSmi(kScratchRegister);
3935 #endif
3932 // Store int value directly to upper half of the smi. 3936 // Store int value directly to upper half of the smi.
3933 STATIC_ASSERT(kSmiTag == 0); 3937 STATIC_ASSERT(kSmiTag == 0);
3934 STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32); 3938 STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);
3935 offset += kPointerSize / 2; 3939 offset += kPointerSize / 2;
3936 representation = Representation::Integer32(); 3940 representation = Representation::Integer32();
3937 } 3941 }
3938 3942
3939 Operand operand = FieldOperand(write_register, offset); 3943 Operand operand = FieldOperand(write_register, offset);
3940 3944
3941 if (instr->value()->IsRegister()) { 3945 if (instr->value()->IsRegister()) {
(...skipping 1603 matching lines...) Expand 10 before | Expand all | Expand 10 after
5545 FixedArray::kHeaderSize - kPointerSize)); 5549 FixedArray::kHeaderSize - kPointerSize));
5546 __ bind(&done); 5550 __ bind(&done);
5547 } 5551 }
5548 5552
5549 5553
5550 #undef __ 5554 #undef __
5551 5555
5552 } } // namespace v8::internal 5556 } } // namespace v8::internal
5553 5557
5554 #endif // V8_TARGET_ARCH_X64 5558 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | test/mjsunit/compiler/smi-stores-opt.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698