Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: src/hydrogen-instructions.h

Issue 152923006: Fix for a smi stores optimization on x64 with a test case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6516 matching lines...) Expand 10 before | Expand all | Expand 10 after
6527 private: 6527 private:
6528 HStoreNamedField(HValue* obj, 6528 HStoreNamedField(HValue* obj,
6529 HObjectAccess access, 6529 HObjectAccess access,
6530 HValue* val, 6530 HValue* val,
6531 StoreFieldOrKeyedMode store_mode = INITIALIZING_STORE) 6531 StoreFieldOrKeyedMode store_mode = INITIALIZING_STORE)
6532 : access_(access), 6532 : access_(access),
6533 new_space_dominator_(NULL), 6533 new_space_dominator_(NULL),
6534 write_barrier_mode_(UPDATE_WRITE_BARRIER), 6534 write_barrier_mode_(UPDATE_WRITE_BARRIER),
6535 has_transition_(false), 6535 has_transition_(false),
6536 store_mode_(store_mode) { 6536 store_mode_(store_mode) {
6537 if (!FLAG_smi_x64_store_opt) store_mode_ = INITIALIZING_STORE;
6538 // Stores to a non existing in-object property are allowed only to the 6537 // Stores to a non existing in-object property are allowed only to the
6539 // newly allocated objects (via HAllocate or HInnerAllocatedObject). 6538 // newly allocated objects (via HAllocate or HInnerAllocatedObject).
6540 ASSERT(!access.IsInobject() || access.existing_inobject_property() || 6539 ASSERT(!access.IsInobject() || access.existing_inobject_property() ||
6541 obj->IsAllocate() || obj->IsInnerAllocatedObject()); 6540 obj->IsAllocate() || obj->IsInnerAllocatedObject());
6542 SetOperandAt(0, obj); 6541 SetOperandAt(0, obj);
6543 SetOperandAt(1, val); 6542 SetOperandAt(1, val);
6544 SetOperandAt(2, obj); 6543 SetOperandAt(2, obj);
6545 access.SetGVNFlags(this, STORE); 6544 access.SetGVNFlags(this, STORE);
6546 } 6545 }
6547 6546
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
6716 private: 6715 private:
6717 HStoreKeyed(HValue* obj, HValue* key, HValue* val, 6716 HStoreKeyed(HValue* obj, HValue* key, HValue* val,
6718 ElementsKind elements_kind, 6717 ElementsKind elements_kind,
6719 StoreFieldOrKeyedMode store_mode = INITIALIZING_STORE) 6718 StoreFieldOrKeyedMode store_mode = INITIALIZING_STORE)
6720 : elements_kind_(elements_kind), 6719 : elements_kind_(elements_kind),
6721 index_offset_(0), 6720 index_offset_(0),
6722 is_dehoisted_(false), 6721 is_dehoisted_(false),
6723 is_uninitialized_(false), 6722 is_uninitialized_(false),
6724 store_mode_(store_mode), 6723 store_mode_(store_mode),
6725 new_space_dominator_(NULL) { 6724 new_space_dominator_(NULL) {
6726 if (!FLAG_smi_x64_store_opt) store_mode_ = INITIALIZING_STORE;
6727 SetOperandAt(0, obj); 6725 SetOperandAt(0, obj);
6728 SetOperandAt(1, key); 6726 SetOperandAt(1, key);
6729 SetOperandAt(2, val); 6727 SetOperandAt(2, val);
6730 6728
6731 ASSERT(store_mode != STORE_TO_INITIALIZED_ENTRY || 6729 ASSERT(store_mode != STORE_TO_INITIALIZED_ENTRY ||
6732 elements_kind == FAST_SMI_ELEMENTS); 6730 elements_kind == FAST_SMI_ELEMENTS);
6733 6731
6734 if (IsFastObjectElementsKind(elements_kind)) { 6732 if (IsFastObjectElementsKind(elements_kind)) {
6735 SetFlag(kTrackSideEffectDominators); 6733 SetFlag(kTrackSideEffectDominators);
6736 SetGVNFlag(kDependsOnNewSpacePromotion); 6734 SetGVNFlag(kDependsOnNewSpacePromotion);
(...skipping 699 matching lines...) Expand 10 before | Expand all | Expand 10 after
7436 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7434 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7437 }; 7435 };
7438 7436
7439 7437
7440 #undef DECLARE_INSTRUCTION 7438 #undef DECLARE_INSTRUCTION
7441 #undef DECLARE_CONCRETE_INSTRUCTION 7439 #undef DECLARE_CONCRETE_INSTRUCTION
7442 7440
7443 } } // namespace v8::internal 7441 } } // namespace v8::internal
7444 7442
7445 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7443 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698