src/hydrogen.cc - Issue 152923006: Fix for a smi stores optimization on x64 with a test case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 152923006: Fix for a smi stores optimization on x64 with a test case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index da415d463717bee4400ac088d80836f2cb672ecb..033a092c0d1580e963506d9114e6b60320069ebf 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -9853,6 +9853,8 @@ void HOptimizedGraphBuilder::BuildEmitInObjectProperties(

value_instruction = double_box;

} else if (representation.IsSmi() && value->IsUninitialized()) {

value_instruction = graph()->GetConstant0();

+ // Ensure that Constant0 is stored as smi.

+ access = access.WithRepresentation(representation);

} else {

value_instruction = Add<HConstant>(value);

}

« no previous file with comments | « src/flag-definitions.h ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »