Support device scale factor test with popups in LayoutTest

Support device scale factor test with popups in LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.
  This is done by compositor in normal scenario.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html

Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
Cr-Commit-Position: refs/heads/master@{#365647}

[oshima, 2015-12-15 03:01:28]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 03:06:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525933002/1

[commit-bot: I haz the power, 2015-12-15 04:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 04:12:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2015-12-15 05:58:00]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 05:59:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525933002/20001

[commit-bot: I haz the power, 2015-12-15 06:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 06:59:18]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-12-15 08:36:54]

Patchset #1 (id:1) has been deleted

[oshima, 2015-12-15 08:42:11]

Description was changed from

==========
LayoutTest

BUG=
==========

to

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send resize request with requested DSF.
* 

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

[oshima, 2015-12-15 08:42:11]

oshima@chromium.org changed reviewers:
+ tkent@chromium.org

[oshima, 2015-12-15 08:44:07]

Description was changed from

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send resize request with requested DSF.
* 

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

to

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

[oshima, 2015-12-15 08:44:18]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 08:44:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525933002/40001

[oshima, 2015-12-15 08:45:30]

Description was changed from

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

to

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

[oshima, 2015-12-15 08:45:54]

Please let me know what you think.

[oshima, 2015-12-15 09:12:55]

Patchset #3 (id:60001) has been deleted

[oshima, 2015-12-15 09:14:28]

Description was changed from

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

to

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

[oshima, 2015-12-15 20:08:08]

Description was changed from

==========
Add device scale factor support with popups to LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

to

==========
Support device scale factor test with popups in LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.
  This is done by compositor in normal scenario.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

[oshima, 2015-12-15 20:21:37]

oshima@chromium.org changed reviewers:
+ mkwst@chromium.org

[oshima, 2015-12-15 20:21:37]

mkwst@, can you review this too?

https://codereview.chromium.org/1525933002/diff/40001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1525933002/diff/40001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:517: return;
I'm doing this to avoid resize request from host, because this extra resize
request can cause flakyness (repaint-shadow.svg was failing on windows, and
crbug.com/569628 can increase the likelihood. ).

Please let me know if you have a suggestion.

[tkent, 2015-12-16 06:40:01]

third_party/WebKit lgtm.

https://codereview.chromium.org/1525933002/diff/40001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1525933002/diff/40001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:517: return;
On 2015/12/15 at 20:21:37, oshima wrote:
> I'm doing this to avoid resize request from host, because this extra resize
request can cause flakyness (repaint-shadow.svg was failing on windows, and
crbug.com/569628 can increase the likelihood. ).
> 
> Please let me know if you have a suggestion.

Hmm, this looks a reasonable solution.

[Mike West, 2015-12-16 08:13:21]

content/shell and components/test_runner LGTM.

[oshima, 2015-12-16 08:19:37]

oshima@chromium.org changed reviewers:
+ sadrul@chromium.org

[oshima, 2015-12-16 08:19:38]

sadrul@ -> components/html_viewer, ui/views/ owner

[sadrul, 2015-12-16 19:13:19]

lgtm

https://codereview.chromium.org/1525933002/diff/40001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_x11.cc (right):

https://codereview.chromium.org/1525933002/diff/40001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_x11.cc:263: 
Perhaps this could go in a TestApi instead.

[oshima, 2015-12-16 21:30:29]

On 2015/12/16 19:13:19, sadrul wrote:
> lgtm
> 
>
https://codereview.chromium.org/1525933002/diff/40001/ui/views/widget/desktop...
> File ui/views/widget/desktop_aura/desktop_screen_x11.cc (right):
> 
>
https://codereview.chromium.org/1525933002/diff/40001/ui/views/widget/desktop...
> ui/views/widget/desktop_aura/desktop_screen_x11.cc:263: 
> Perhaps this could go in a TestApi instead.

I sent you https://codereview.chromium.org/1534563002

[oshima, 2015-12-16 21:30:37]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-12-16 21:33:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525933002/40001

[commit-bot: I haz the power, 2015-12-16 22:40:23]

Description was changed from

==========
Support device scale factor test with popups in LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.
  This is done by compositor in normal scenario.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

to

==========
Support device scale factor test with popups in LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.
  This is done by compositor in normal scenario.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

[commit-bot: I haz the power, 2015-12-16 22:40:24]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-16 22:42:26]

Description was changed from

==========
Support device scale factor test with popups in LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.
  This is done by compositor in normal scenario.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html
==========

to

==========
Support device scale factor test with popups in LayoutTest

* Sends DSF to host so that host can send a resize request with requested DSF.
* Updated X11's screen so that displays contains specified DSF.
  This is used by RWH to construct WebScreenInfo with updated DSF.
  - Win/Mac will use the DSF specified by command line flag.
* Scale the popup location based on the device scale factor.
  This is done by compositor in normal scenario.

BUG=567837
TEST=added popu-menu-appearance-dsf2.html

Committed: https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
Cr-Commit-Position: refs/heads/master@{#365647}
==========

[commit-bot: I haz the power, 2015-12-16 22:42:28]

Patchset 2 (id:??) landed as
https://crrev.com/76ebe14aeee04f02c62273c638e110f621c162aa
Cr-Commit-Position: refs/heads/master@{#365647}

[wkorman, 2015-12-20 03:21:43]

wkorman@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2015-12-20 03:21:44]

Following up per noel@ pointer to this change -- does anything ensure that we
return the test runner to its original state at the end of the test? For
example, see:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

but there are other places we do similar such as:

https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/blin...

We are looking into http://crbug.com/570401 where the auto-rebaseline bot seems
to be generating some baselines with a root layer size of 1600x1200 rather than
800x600. It started around the time this change went in.

[Noel Gordon, 2015-12-20 23:56:14]

Reverting here to try and bring the rebaseline server back to sanity.

[Noel Gordon, 2015-12-20 23:58:55]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1541713002/ by noel@chromium.org.

The reason for reverting is: Looking into http://crbug.com/where the
auto-rebaseline server
seems to be generating some baselines with a root layer size of 1600x1200
rather than 800x600, or is producing all white image results. It started
around the time this change went in.  Reverting here to attempt to
restore the rebaseline server..