Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1534563002: Move to DesktopScreenX11::UpdateDeviceScaleFactor to TestApi (Closed)

Created:
5 years ago by oshima
Modified:
5 years ago
Reviewers:
sadrul, Mike West
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tdanderson+views_chromium.org, Peter Beverloo, tfarina, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move to DesktopScreenX11::UpdateDeviceScaleFactor to TestApi BUG=None TBR=mkwst@chromium.org Committed: https://crrev.com/5738eb5987aa06628a0d22d6c5ce7c33fe6b4c10 Cr-Commit-Position: refs/heads/master@{#366058}

Patch Set 1 : #

Patch Set 2 : fix win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -11 lines) Patch
M content/shell/browser/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A ui/views/test/desktop_screen_x11_test_api.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/views/test/desktop_screen_x11_test_api.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
oshima
5 years ago (2015-12-16 21:30:02 UTC) #4
sadrul
Thank you! lgtm
5 years ago (2015-12-18 05:47:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534563002/20001
5 years ago (2015-12-18 05:51:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/130316)
5 years ago (2015-12-18 05:59:32 UTC) #9
oshima
TBR'ing mkwst@ for trivial change in content/shell/browser/shell.cc
5 years ago (2015-12-18 08:03:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534563002/40001
5 years ago (2015-12-18 08:03:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-18 08:52:59 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-18 08:53:51 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5738eb5987aa06628a0d22d6c5ce7c33fe6b4c10
Cr-Commit-Position: refs/heads/master@{#366058}

Powered by Google App Engine
This is Rietveld 408576698