Support device scale factor test with popups in LayoutTest

content/shell/renderer/layout_test/blink_test_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/layout_test/blink_test_runner.h"
 
 #include <algorithm>
 #include <clocale>
 #include <cmath>
 
@@ skipping 14 matching lines @@
 #include "base/time/time.h"
 #include "components/plugins/renderer/plugin_placeholder.h"
 #include "components/test_runner/app_banner_client.h"
 #include "components/test_runner/gamepad_controller.h"
 #include "components/test_runner/mock_screen_orientation_client.h"
 #include "components/test_runner/test_interfaces.h"
 #include "components/test_runner/web_task.h"
 #include "components/test_runner/web_test_interfaces.h"
 #include "components/test_runner/web_test_proxy.h"
 #include "components/test_runner/web_test_runner.h"
+#include "content/common/content_switches_internal.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/common/web_preferences.h"
 #include "content/public/renderer/media_stream_api.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/render_view_visitor.h"
 #include "content/public/renderer/renderer_gamepad_provider.h"
 #include "content/public/test/layouttest_support.h"
 #include "content/shell/common/layout_test/layout_test_messages.h"
@@ skipping 213 matching lines @@
 
 }  // namespace
 
 BlinkTestRunner::BlinkTestRunner(RenderView* render_view)
     : RenderViewObserver(render_view),
       RenderViewObserverTracker<BlinkTestRunner>(render_view),
       proxy_(NULL),
       focused_view_(NULL),
       is_main_window_(false),
       focus_on_next_commit_(false),
-      leak_detector_(new LeakDetector(this)) {
-}
+      leak_detector_(new LeakDetector(this)),
+      device_scale_factor_(1.f) {}
 
 BlinkTestRunner::~BlinkTestRunner() {
 }
 
 // WebTestDelegate  -----------------------------------------------------------
 
 void BlinkTestRunner::ClearEditCommand() {
   render_view()->ClearEditCommands();
 }
 
@@ skipping 225 matching lines @@
   Send(new LayoutTestHostMsg_SetDatabaseQuota(routing_id(), quota));
 }
 
 void BlinkTestRunner::SimulateWebNotificationClick(const std::string& title,
                                                    int action_index) {
   Send(new LayoutTestHostMsg_SimulateWebNotificationClick(routing_id(), title,
                                                           action_index));
 }
 
 void BlinkTestRunner::SetDeviceScaleFactor(float factor) {
+  if (device_scale_factor_ == factor)
+    return;

[oshima, 2015/12/15 20:21:37]

I'm doing this to avoid resize request from host, because this extra resize
request can cause flakyness (repaint-shadow.svg was failing on windows, and
crbug.com/569628 can increase the likelihood. ).

Please let me know if you have a suggestion.

[tkent, 2015/12/16 06:40:01]

Hmm, this looks a reasonable solution.

+  device_scale_factor_ = factor;
   content::SetDeviceScaleFactor(render_view(), factor);
+  Send(new ShellViewHostMsg_SetDeviceScaleFactor(routing_id(), factor));
 }
 
 void BlinkTestRunner::SetDeviceColorProfile(const std::string& name) {
   content::SetDeviceColorProfile(render_view(), name);
 }
 
 void BlinkTestRunner::SetBluetoothMockDataSet(const std::string& name) {
   Send(new LayoutTestHostMsg_SetBluetoothAdapter(name));
   // Auto-reset the chooser type so we don't get order dependence when some
   // tests forget to do it explicitly.
@@ skipping 227 matching lines @@
   plugins::PluginPlaceholder* placeholder =
       new plugins::PluginPlaceholder(render_view()->GetMainRenderFrame(), frame,
                                      params, "<div>Test content</div>");
   return placeholder->plugin();
 }
 
 void BlinkTestRunner::OnWebTestProxyBaseDestroy(
     test_runner::WebTestProxyBase* proxy) {
 }
 
+blink::WebPoint BlinkTestRunner::ConvertDIPToNative(
+    const blink::WebPoint& point_in_dip) const {
+  return blink::WebPoint(point_in_dip.x * device_scale_factor_,
+                         point_in_dip.y * device_scale_factor_);
+}
 bool BlinkTestRunner::AddMediaStreamVideoSourceAndTrack(
     blink::WebMediaStream* stream) {
   DCHECK(stream);
 #if defined(ENABLE_WEBRTC)
   return AddVideoTrackToMediaStream(
       make_scoped_ptr(new MockVideoCapturerSource()),
       false /* is_remote */, false /* is_readonly */, stream);
 #else
   return false;
 #endif
@@ skipping 217 matching lines @@
   get_bluetooth_events_callbacks_.pop_front();
   callback.Run(events);
 }
 
 void BlinkTestRunner::ReportLeakDetectionResult(
     const LeakDetectionResult& report) {
   Send(new ShellViewHostMsg_LeakDetectionDone(routing_id(), report));
 }
 
 }  // namespace content