Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1850)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1525933002: Support device scale factor test with popups in LayoutTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_test_delegate.h ('k') | content/shell/browser/blink_test_controller.h » ('j') | content/shell/renderer/layout_test/blink_test_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_test_proxy.cc
diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc
index 44a1fc9740c153d690655a151ce3ff64b6ff938c..90c6c4649bbbb9341bba37aaaf472da4ddc42899 100644
--- a/components/test_runner/web_test_proxy.cc
+++ b/components/test_runner/web_test_proxy.cc
@@ -670,7 +670,8 @@ void WebTestProxyBase::CapturePixelsAsync(
web_widget_->compositeAndReadbackAsync(capture_callback);
if (blink::WebPagePopup* popup = web_widget_->pagePopup()) {
capture_callback->set_wait_for_popup(true);
- capture_callback->set_popup_position(popup->positionRelativeToOwner());
+ capture_callback->set_popup_position(
+ delegate_->ConvertDIPToNative(popup->positionRelativeToOwner()));
popup->compositeAndReadbackAsync(capture_callback);
}
}
« no previous file with comments | « components/test_runner/web_test_delegate.h ('k') | content/shell/browser/blink_test_controller.h » ('j') | content/shell/renderer/layout_test/blink_test_runner.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698