Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1525183002: tools/gn: rename char_offset to column_number (Closed)

Created:
5 years ago by tfarina
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: rename char_offset to column_number While looking at Location and trying to understand what char offset meant, I got very confused, because in some languages, like Portuguese, it is hard to translate offset and thus understand what it means. Actually char offset is referring to the column number in text buffer, which is much easier to understand and its meaning is instantly understood, since everyone is familiar with the concenpt of rows (lines) and columns in a text editor. BUG=None TEST=gn gen + gn_unittests R=brettw@chromium.org Committed: https://crrev.com/21aff0d0e90b1fc419971485150f76c4d2458e13 Cr-Commit-Position: refs/heads/master@{#367883}

Patch Set 1 #

Patch Set 2 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M tools/gn/c_include_iterator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/err.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/header_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/input_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/location.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/location.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M tools/gn/parse_tree.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/parse_tree_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/parser_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/string_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/gn/token.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/tokenizer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/tokenizer.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
5 years ago (2015-12-15 17:06:54 UTC) #1
brettw
lgtm
4 years, 11 months ago (2016-01-06 19:06:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525183002/20001
4 years, 11 months ago (2016-01-06 19:23:37 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 19:50:15 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 19:51:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21aff0d0e90b1fc419971485150f76c4d2458e13
Cr-Commit-Position: refs/heads/master@{#367883}

Powered by Google App Engine
This is Rietveld 408576698