Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: tools/gn/parser_unittest.cc

Issue 1525183002: tools/gn: rename char_offset to column_number (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix indentation Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/parse_tree_unittest.cc ('k') | tools/gn/string_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/parser_unittest.cc
diff --git a/tools/gn/parser_unittest.cc b/tools/gn/parser_unittest.cc
index 39b69b7845c619f1d2709b2ae3330957d7944d69..b6c200978ccf7ec98649c3ef8a3b83ad4aae0861 100644
--- a/tools/gn/parser_unittest.cc
+++ b/tools/gn/parser_unittest.cc
@@ -68,7 +68,7 @@ void DoParserErrorTest(const char* input, int err_line, int err_char) {
}
EXPECT_EQ(err_line, err.location().line_number());
- EXPECT_EQ(err_char, err.location().char_offset());
+ EXPECT_EQ(err_char, err.location().column_number());
}
// Expects the tokenizer or parser to identify an error at the given line and
@@ -86,7 +86,7 @@ void DoExpressionErrorTest(const char* input, int err_line, int err_char) {
}
EXPECT_EQ(err_line, err.location().line_number());
- EXPECT_EQ(err_char, err.location().char_offset());
+ EXPECT_EQ(err_char, err.location().column_number());
}
} // namespace
« no previous file with comments | « tools/gn/parse_tree_unittest.cc ('k') | tools/gn/string_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698