Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: tools/gn/c_include_iterator_unittest.cc

Issue 1525183002: tools/gn: rename char_offset to column_number (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix indentation Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/err.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/c_include_iterator_unittest.cc
diff --git a/tools/gn/c_include_iterator_unittest.cc b/tools/gn/c_include_iterator_unittest.cc
index 1add29b53aab8541408aa848968c51c3d973814f..98458b9e6c21c5dd3f91c15b0457dad57c9b129f 100644
--- a/tools/gn/c_include_iterator_unittest.cc
+++ b/tools/gn/c_include_iterator_unittest.cc
@@ -13,8 +13,8 @@ bool RangeIs(const LocationRange& range,
int line, int begin_char, int end_char) {
return range.begin().line_number() == line &&
range.end().line_number() == line &&
- range.begin().char_offset() == begin_char &&
- range.end().char_offset() == end_char;
+ range.begin().column_number() == begin_char &&
+ range.end().column_number() == end_char;
}
} // namespace
« no previous file with comments | « no previous file | tools/gn/err.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698