tools/gn/token.h - Issue 1525183002: tools/gn: rename char_offset to column_number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/token.h

Issue 1525183002: tools/gn: rename char_offset to column_number (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix indentation Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/token.h

diff --git a/tools/gn/token.h b/tools/gn/token.h

index 45b6e28ced214c2bb94fff785b9c44908c7c04c7..bf8728377a12b1e3c03e66e244b37dcbada56fa1 100644

--- a/tools/gn/token.h

+++ b/tools/gn/token.h

@@ -68,7 +68,7 @@ class Token {

location_,

Location(location_.file(),

location_.line_number(),

- location_.char_offset() + static_cast<int>(value_.size()),

+ location_.column_number() + static_cast<int>(value_.size()),

location_.byte() + static_cast<int>(value_.size())));

}

« no previous file with comments | « tools/gn/string_utils.cc ('k') | tools/gn/tokenizer.h » ('j') | no next file with comments »