Fix a crash when 'input' event handler for input[type=color] change the input type.

Fix a crash when 'input' event handler for input[type=color] change the input type.

Delaying 'input' event dispatched by HTMLInputElement::setValueFromRenderer().

BUG=569170
TEST=automated

Committed: https://crrev.com/a17cb3ecef49a078657524cdeaba33ad2083646c
Cr-Commit-Position: refs/heads/master@{#364979}

[tkent, 2015-12-14 01:08:20]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2015-12-14 01:08:20]

Keishi, would you review this please?

[tkent, 2015-12-14 03:39:10]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org
- keishi@chromium.org

[tkent, 2015-12-14 03:39:11]

kochi-san, would you review this please?

[kochi, 2015-12-14 05:01:44]

https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLInputElement.h (right):

https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLInputElement.h:139: // It dispatched
'input' event for non-textfield types.
This comment isn't clear to me.  What is "It"?
Why is this past tense?  Callers must make sure dispatch 'input'
event before calling setValueFromRenderer()?

[tkent, 2015-12-14 05:18:19]

Thank you for reviewing.  Updated the patch.

https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLInputElement.h (right):

https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLInputElement.h:139: // It dispatched
'input' event for non-textfield types.
On 2015/12/14 at 05:01:44, kochi wrote:
> This comment isn't clear to me.  What is "It"?
> Why is this past tense?  Callers must make sure dispatch 'input'
> event before calling setValueFromRenderer()?

I'm sorry for the unclear comment.
- it -> This function
- dispatched: typo, dispatches
- Add a sentence about what callers should do.

[kochi, 2015-12-14 05:22:20]

Thanks for the clarification, it makes sense!

lgtm

[tkent, 2015-12-14 06:32:59]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-12-14 06:34:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523633002/20001

[commit-bot: I haz the power, 2015-12-14 07:34:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-14 07:35:15]

Description was changed from

==========
Fix a crash when 'input' event handler for input[type=color] change the input
type.

Delaying 'input' event dispatched by HTMLInputElement::setValueFromRenderer().

BUG=569170
TEST=automated
==========

to

==========
Fix a crash when 'input' event handler for input[type=color] change the input
type.

Delaying 'input' event dispatched by HTMLInputElement::setValueFromRenderer().

BUG=569170
TEST=automated

Committed: https://crrev.com/a17cb3ecef49a078657524cdeaba33ad2083646c
Cr-Commit-Position: refs/heads/master@{#364979}
==========

[commit-bot: I haz the power, 2015-12-14 07:35:15]

Patchset 2 (id:??) landed as
https://crrev.com/a17cb3ecef49a078657524cdeaba33ad2083646c
Cr-Commit-Position: refs/heads/master@{#364979}