third_party/WebKit/Source/core/html/forms/ColorInputType.cpp - Issue 1523633002: Fix a crash when 'input' event handler for input[type=color] change the input type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 1523633002: Fix a crash when 'input' event handler for input[type=color] change the input type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update the comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

index 25c73d726d21f5b14dcd43d166d6548a7a92f900..efab8d94c4c0fee0ae8e85f05159f58c555f900d 100644

--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

@@ -206,6 +206,7 @@ void ColorInputType::didChooseColor(const Color& color)

{

if (element().isDisabledFormControl() || color == valueAsColor())

return;

+ EventQueueScope scope;

element().setValueFromRenderer(color.serialized());

element().updateView();

if (!LayoutTheme::theme().isModalColorChooser())

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »