Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 1523633002: Fix a crash when 'input' event handler for input[type=color] change the input type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update the comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
index 25c73d726d21f5b14dcd43d166d6548a7a92f900..efab8d94c4c0fee0ae8e85f05159f58c555f900d 100644
--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
@@ -206,6 +206,7 @@ void ColorInputType::didChooseColor(const Color& color)
{
if (element().isDisabledFormControl() || color == valueAsColor())
return;
+ EventQueueScope scope;
element().setValueFromRenderer(color.serialized());
element().updateView();
if (!LayoutTheme::theme().isModalColorChooser())
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698