third_party/WebKit/Source/core/html/HTMLInputElement.h - Issue 1523633002: Fix a crash when 'input' event handler for input[type=color] change the input type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 1523633002: Fix a crash when 'input' event handler for input[type=color] change the input type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update the comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/color/color-type-change-on-input-crash.html ('k') | third_party/WebKit/Source/core/html/forms/ColorInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h

index 2d28e4b314fd35c3adf1e1b66207925cd06e08bf..92275235055278524e1d8a9f160f8432d29403cb 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h

@@ -136,6 +136,9 @@ public:

String valueWithDefault() const;

+ // This function dispatches 'input' event for non-textfield types. Callers

+ // need to handle any DOM structure changes by event handlers, or need to

+ // delay the 'input' event with EventQueueScope.

void setValueFromRenderer(const String&);

int selectionStartForBinding(ExceptionState&) const;