Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(191)

Issue 1523633002: Fix a crash when 'input' event handler for input[type=color] change the input type. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, keishi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when 'input' event handler for input[type=color] change the input type. Delaying 'input' event dispatched by HTMLInputElement::setValueFromRenderer(). BUG=569170 TEST=automated Committed: https://crrev.com/a17cb3ecef49a078657524cdeaba33ad2083646c Cr-Commit-Position: refs/heads/master@{#364979}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/color/color-type-change-on-input-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tkent
Keishi, would you review this please?
4 years, 2 months ago (2015-12-14 01:08:20 UTC) #2
tkent
kochi-san, would you review this please?
4 years, 2 months ago (2015-12-14 03:39:11 UTC) #4
kochi
https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/core/html/HTMLInputElement.h File third_party/WebKit/Source/core/html/HTMLInputElement.h (right): https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/core/html/HTMLInputElement.h#newcode139 third_party/WebKit/Source/core/html/HTMLInputElement.h:139: // It dispatched 'input' event for non-textfield types. This ...
4 years, 2 months ago (2015-12-14 05:01:44 UTC) #5
tkent
Thank you for reviewing. Updated the patch. https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/core/html/HTMLInputElement.h File third_party/WebKit/Source/core/html/HTMLInputElement.h (right): https://codereview.chromium.org/1523633002/diff/1/third_party/WebKit/Source/core/html/HTMLInputElement.h#newcode139 third_party/WebKit/Source/core/html/HTMLInputElement.h:139: // It ...
4 years, 2 months ago (2015-12-14 05:18:19 UTC) #6
kochi
Thanks for the clarification, it makes sense! lgtm
4 years, 2 months ago (2015-12-14 05:22:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523633002/20001
4 years, 2 months ago (2015-12-14 06:34:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2015-12-14 07:34:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2015-12-14 07:35:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a17cb3ecef49a078657524cdeaba33ad2083646c
Cr-Commit-Position: refs/heads/master@{#364979}

Powered by Google App Engine
This is Rietveld 408576698