Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1521913002: PDF: Delete non-material viewer (Closed)

Created:
5 years ago by tsergeant
Modified:
5 years ago
CC:
arv+watch_chromium.org, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Delete non-material viewer Removes all the viewer code for the old design, the --enable-pdf-material-ui flag, and the associated tests. BUG=439114 Committed: https://crrev.com/c7e23485fd8e9a1313b9bab9ad963a433b4bd9a9 Cr-Commit-Position: refs/heads/master@{#365205}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -950 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_test.cc View 1 4 chunks +11 lines, -60 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_util.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 4 chunks +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_fit_page.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_fit_width.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_play.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_print.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_save.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_zoom_in.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_zoom_out.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_fit_page.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_fit_width.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_play.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_print.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_save.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_zoom_in.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_zoom_out.png View Binary file 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/viewer-button.css View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/viewer-button.html View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-button/viewer-button.js View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-error-screen-legacy/viewer-error-screen-legacy.css View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-error-screen-legacy/viewer-error-screen-legacy.html View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-error-screen-legacy/viewer-error-screen-legacy.js View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-password-screen-legacy/viewer-password-screen-legacy.css View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-password-screen-legacy/viewer-password-screen-legacy.html View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-password-screen-legacy/viewer-password-screen-legacy.js View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.css View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.html View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.js View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.css View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.html View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.js View 1 chunk +0 lines, -74 lines 0 comments Download
M chrome/browser/resources/pdf/index.css View 1 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/resources/pdf/index.html View 1 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/resources/pdf/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 15 chunks +66 lines, -135 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 1 chunk +6 lines, -17 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/test/data/pdf/basic_test.js View 1 1 chunk +0 lines, -41 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (9 generated)
tsergeant
Delta is +85/-950 =D I've got a follow-up patch which renames lots of the 'material' ...
5 years ago (2015-12-14 05:42:36 UTC) #5
raymes
lgtm!
5 years ago (2015-12-14 22:59:11 UTC) #6
tsergeant
estade@chromium.org: Please review changes in component_extension_resources.grd!
5 years ago (2015-12-14 23:13:39 UTC) #8
Sam McNally
lgtm
5 years ago (2015-12-14 23:44:03 UTC) #9
Evan Stade
chrome/browser/resources/component_extension_resources.grd lgtm!
5 years ago (2015-12-15 00:04:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521913002/40001
5 years ago (2015-12-15 00:38:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-15 04:20:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521913002/40001
5 years ago (2015-12-15 04:24:54 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 07:57:36 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-15 07:58:48 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c7e23485fd8e9a1313b9bab9ad963a433b4bd9a9
Cr-Commit-Position: refs/heads/master@{#365205}

Powered by Google App Engine
This is Rietveld 408576698