Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1530573002: PDF: Add alt/option key to Go To Page keyboard shortcut (Closed)

Created:
5 years ago by tsergeant
Modified:
5 years ago
Reviewers:
raymes
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf_remove_non_material
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Add alt/option key to Go To Page keyboard shortcut The shortcut is now Ctrl-Alt-G or Command-Option-G, which removes the collision with the built in find-in-page shortcut, and matches other PDF software. BUG=55920 Committed: https://crrev.com/c2e749fd466f83210771660d98b9ab4d74da3369 Cr-Commit-Position: refs/heads/master@{#365377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
tsergeant
5 years ago (2015-12-15 04:44:10 UTC) #2
raymes
lgtm
5 years ago (2015-12-15 05:21:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530573002/1
5 years ago (2015-12-15 22:00:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 23:14:03 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 23:14:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2e749fd466f83210771660d98b9ab4d74da3369
Cr-Commit-Position: refs/heads/master@{#365377}

Powered by Google App Engine
This is Rietveld 408576698