Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1527453002: PDF: Remove 'material' from file and variable names (Closed)

Created:
5 years ago by tsergeant
Modified:
5 years ago
Reviewers:
raymes, Evan Stade
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf_remove_non_material
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Remove 'material' from file and variable names This is an unnecessary qualifier, since there's no longer anything which is not material. BUG=439114 Committed: https://crrev.com/32912c7e691c00b0d167217882eec0271e77650e Cr-Commit-Position: refs/heads/master@{#365687}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -253 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/resources/pdf/index.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/pdf/index.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/pdf/index-material.css View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/resources/pdf/index-material.html View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/browser/resources/pdf/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 7 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/pdf/basic_test.js View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/test/data/pdf/basic_test_material.js View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/test/data/pdf/toolbar_manager_test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
tsergeant
5 years ago (2015-12-16 06:34:08 UTC) #3
raymes
lgtm
5 years ago (2015-12-16 07:23:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527453002/20001
5 years ago (2015-12-16 22:44:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/129703)
5 years ago (2015-12-16 23:05:43 UTC) #8
tsergeant
oh, whoops. +estade@ for one more change to component_extension_resources.grd
5 years ago (2015-12-16 23:21:12 UTC) #10
Evan Stade
On 2015/12/16 23:21:12, tsergeant wrote: > oh, whoops. +estade@ for one more change to component_extension_resources.grd ...
5 years ago (2015-12-16 23:22:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527453002/20001
5 years ago (2015-12-17 00:06:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 02:45:45 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-17 02:47:32 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/32912c7e691c00b0d167217882eec0271e77650e
Cr-Commit-Position: refs/heads/master@{#365687}

Powered by Google App Engine
This is Rietveld 408576698