Subzero: Fix mid-line comments when using -asm-verbose .

Subzero: Fix mid-line comments when using -asm-verbose .

The llvm-mc assembler for x86 uses '#' to start a mid-line comment, while arm32 uses '@'.  Those characters cause syntax errors for the other architecture.  There doesn't seem to be a common character for starting mid-line comments.

However, the /* ... */ style comment works in both (all?) cases.

(The '#' character at the start of a line, preceded by optional whitespace, starts a comment in both cases.)

BUG= none
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose --target=arm32
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose --target=x8632
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=751e27ec04c25d974b08b46305271729ada153dc

[Jim Stichnoth, 2015-12-13 15:33:06]

Description was changed from

==========
Subzero: Fix mid-line comments when using -asm-verbose .

BUG= none
==========

to

==========
Subzero: Fix mid-line comments when using -asm-verbose .

The llvm-mc assembler for x86 uses '#' to start a mid-line comment, while arm32
uses '@'.  Those characters cause syntax errors for the other architecture. 
There doesn't seem to be a common character for starting mid-line comments.

However, the /* ... */ style comment works in both (all?) cases.

BUG= none
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=arm32
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=x8632
==========

[Jim Stichnoth, 2015-12-13 15:33:06]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Jim Stichnoth, 2015-12-13 15:38:51]

Description was changed from

==========
Subzero: Fix mid-line comments when using -asm-verbose .

The llvm-mc assembler for x86 uses '#' to start a mid-line comment, while arm32
uses '@'.  Those characters cause syntax errors for the other architecture. 
There doesn't seem to be a common character for starting mid-line comments.

However, the /* ... */ style comment works in both (all?) cases.

BUG= none
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=arm32
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=x8632
==========

to

==========
Subzero: Fix mid-line comments when using -asm-verbose .

The llvm-mc assembler for x86 uses '#' to start a mid-line comment, while arm32
uses '@'.  Those characters cause syntax errors for the other architecture. 
There doesn't seem to be a common character for starting mid-line comments.

However, the /* ... */ style comment works in both (all?) cases.

(The '#' character at the start of a line, preceded by optional whitespace,
starts a comment in both cases.)

BUG= none
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=arm32
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=x8632
==========

[Jim Stichnoth, 2015-12-13 15:40:46]

The ARM target data lowering still uses '@' style comments for commenting
".eabi_attribute" lines.  I decided not to touch them, but I can make the same
change if jpp@ wants.

[Karl, 2015-12-16 16:50:21]

lgtm

[Jim Stichnoth, 2015-12-16 20:40:34]

Description was changed from

==========
Subzero: Fix mid-line comments when using -asm-verbose .

The llvm-mc assembler for x86 uses '#' to start a mid-line comment, while arm32
uses '@'.  Those characters cause syntax errors for the other architecture. 
There doesn't seem to be a common character for starting mid-line comments.

However, the /* ... */ style comment works in both (all?) cases.

(The '#' character at the start of a line, preceded by optional whitespace,
starts a comment in both cases.)

BUG= none
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=arm32
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=x8632
==========

to

==========
Subzero: Fix mid-line comments when using -asm-verbose .

The llvm-mc assembler for x86 uses '#' to start a mid-line comment, while arm32
uses '@'.  Those characters cause syntax errors for the other architecture. 
There doesn't seem to be a common character for starting mid-line comments.

However, the /* ... */ style comment works in both (all?) cases.

(The '#' character at the start of a line, preceded by optional whitespace,
starts a comment in both cases.)

BUG= none
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=arm32
TEST= ./pydir/szbuild_spec2k.py --force -v -O2 --filetype=asm --sz=--asm-verbose
--target=x8632
R=kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2015-12-16 20:40:35]

Committed patchset #2 (id:20001) manually as
751e27ec04c25d974b08b46305271729ada153dc (presubmit successful).