Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: src/IceCfgNode.cpp

Issue 1521863002: Subzero: Fix mid-line comments when using -asm-verbose . (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix lit tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceInstX86BaseImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfgNode.cpp
diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp
index 96a770a4725b3d77e8840d482623d9e4661159b4..f23ae0feade7250b0f04e784cf50f66ab79e716e 100644
--- a/src/IceCfgNode.cpp
+++ b/src/IceCfgNode.cpp
@@ -917,10 +917,10 @@ void emitRegisterUsage(Ostream &Str, const Cfg *Func, const CfgNode *Node,
const int32_t FrameOrStackReg = Func->getTarget()->getFrameOrStackReg();
if (IsLiveIn) {
Live = &Liveness->getLiveIn(Node);
- Str << "\t\t\t\t# LiveIn=";
+ Str << "\t\t\t\t/* LiveIn=";
} else {
Live = &Liveness->getLiveOut(Node);
- Str << "\t\t\t\t# LiveOut=";
+ Str << "\t\t\t\t/* LiveOut=";
}
if (!Live->empty()) {
CfgVector<Variable *> LiveRegs;
@@ -951,7 +951,7 @@ void emitRegisterUsage(Ostream &Str, const Cfg *Func, const CfgNode *Node,
Var->emit(Func);
}
}
- Str << "\n";
+ Str << " */\n";
}
/// Returns true if some text was emitted - in which case the caller definitely
@@ -981,11 +981,13 @@ bool emitLiveRangesEnded(Ostream &Str, const Cfg *Func, const Inst *Instr,
if (Printed)
Str << ",";
else
- Str << " \t@ END=";
+ Str << " \t/* END=";
Var->emit(Func);
Printed = true;
}
}
+ if (Printed)
+ Str << " */";
return Printed;
}
@@ -1029,7 +1031,7 @@ void CfgNode::emit(Cfg *Func) const {
constexpr bool IsLiveIn = true;
emitRegisterUsage(Str, Func, this, IsLiveIn, LiveRegCount);
if (getInEdges().size()) {
- Str << "\t\t\t\t# preds=";
+ Str << "\t\t\t\t/* preds=";
bool First = true;
for (CfgNode *I : getInEdges()) {
if (!First)
@@ -1037,10 +1039,10 @@ void CfgNode::emit(Cfg *Func) const {
First = false;
Str << "$" << I->getName();
}
- Str << "\n";
+ Str << " */\n";
}
if (getLoopNestDepth()) {
- Str << "\t\t\t\t# loop depth=" << getLoopNestDepth() << "\n";
+ Str << "\t\t\t\t/* loop depth=" << getLoopNestDepth() << " */\n";
}
}
« no previous file with comments | « no previous file | src/IceInstX86BaseImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698