Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process. (Closed)

Created:
5 years ago by Ted C
Modified:
5 years ago
Reviewers:
Yusuf, Yaron
CC:
chromium-reviews, tim+watch_chromium.org, davidben+watch_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, tburkard+watch_chromium.org, maxbogue+watch_chromium.org, gavinp+prer_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the ChromeBrowserInitializer the only way to start the browser process. Removes the need for talking to the Android application, which will allow us to slowly move browser specific class initialization to something browser process specific. BUG=482445 Committed: https://crrev.com/6c5bbb3ce0d88c89205776a553158c444c393c99 Cr-Commit-Position: refs/heads/master@{#364900}

Patch Set 1 #

Total comments: 2

Patch Set 2 : yfriedman@ comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -102 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 4 chunks +1 line, -49 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivity.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 6 chunks +80 lines, -25 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/init/EmptyBrowserParts.java View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/AccountsChangedReceiver.java View 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseActivity.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ted C
PTAL
5 years ago (2015-12-11 19:59:27 UTC) #2
Yusuf
lgtm
5 years ago (2015-12-11 21:06:26 UTC) #3
Yaron
lgtm nice start! https://codereview.chromium.org/1521013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java (right): https://codereview.chromium.org/1521013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java#newcode161 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:161: private static void initializeBrowser(final ChromeApplication app) ...
5 years ago (2015-12-11 22:11:08 UTC) #4
Ted C
https://codereview.chromium.org/1521013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java (right): https://codereview.chromium.org/1521013002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java#newcode161 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:161: private static void initializeBrowser(final ChromeApplication app) { On 2015/12/11 ...
5 years ago (2015-12-12 01:29:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521013002/20001
5 years ago (2015-12-12 03:25:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-12 04:16:39 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-12 04:17:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c5bbb3ce0d88c89205776a553158c444c393c99
Cr-Commit-Position: refs/heads/master@{#364900}

Powered by Google App Engine
This is Rietveld 408576698