chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java - Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yfriedman@ comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

index 074c1412524b5d2b51139224a7695ad1d7352921..d955cab4efe8762cb4853b8620a90f465f253676 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

@@ -39,6 +39,7 @@ import org.chromium.chrome.browser.bookmark.BookmarkColumns;

import org.chromium.chrome.browser.bookmark.SearchColumns;

import org.chromium.chrome.browser.database.SQLiteCursor;

import org.chromium.chrome.browser.externalauth.ExternalAuthUtils;

+import org.chromium.chrome.browser.init.ChromeBrowserInitializer;

import org.chromium.content.app.ContentApplication;

import org.chromium.content.browser.BrowserStartupController;

import org.chromium.sync.AndroidSyncSettings;

@@ -792,9 +793,8 @@ public class ChromeBrowserProvider extends ContentProvider {

public void run() {

if (mNativeChromeBrowserProvider != 0) return;

try {

- ((ChromeApplication) getContext().getApplicationContext())

- .startBrowserProcessesAndLoadLibrariesSync(

- true /*Start GoogleServicesManager*/);

+ ChromeBrowserInitializer.getInstance(getContext())

+ .handleSynchronousStartup();

} catch (ProcessInitException e) {

// Chrome browser runs in the background, so exit silently; but do exit,

// since otherwise the next attempt to use Chrome will find a broken JNI.