chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java - Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java

Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yfriedman@ comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java

index 9a480029044a7876e5c2b7b43131d29164b703b9..551892b6f2bbc19e12fe424b050814160af3312c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivityBase.java

@@ -10,6 +10,7 @@ import android.util.Log;

import org.chromium.base.library_loader.ProcessInitException;

import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.init.ChromeBrowserInitializer;

/**

* Activity base class that all the EnhnacedBookmark activities inherit. Currently it's responsible

@@ -23,8 +24,7 @@ abstract class EnhancedBookmarkActivityBase extends AppCompatActivity {

super.onCreate(savedInstanceState);

// Ensure that native library is loaded.

try {

- ((ChromeApplication) getApplication())

- .startBrowserProcessesAndLoadLibrariesSync(true);

+ ChromeBrowserInitializer.getInstance(this).handleSynchronousStartup();

} catch (ProcessInitException e) {

Log.e(TAG, "Failed to start browser process.", e);

ChromeApplication.reportStartupErrorAndExit(e);