chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java - Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

Issue 1521013002: Make the ChromeBrowserInitializer the only way to start the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yfriedman@ comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/init/EmptyBrowserParts.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

index 502edf5787bf8b88ca263314891f9a557e57c32a..44ed46bc564cb609582acc0b098579a227aa4ed4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java

@@ -32,6 +32,7 @@ import org.chromium.base.library_loader.ProcessInitException;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.help.HelpAndFeedback;

+import org.chromium.chrome.browser.init.ChromeBrowserInitializer;

import org.chromium.chrome.browser.profiles.Profile;

/**

@@ -70,7 +71,7 @@ public class Preferences extends AppCompatActivity implements

// killed, or for tests. This should happen before super.onCreate() because it might

// recreate a fragment, and a fragment might depend on the native library.

try {

- ((ChromeApplication) getApplication()).startBrowserProcessesAndLoadLibrariesSync(true);

+ ChromeBrowserInitializer.getInstance(this).handleSynchronousStartup();

} catch (ProcessInitException e) {

Log.e(TAG, "Failed to start browser process.", e);

// This can only ever happen, if at all, when the activity is started from an Android